chore: Bump some dependency versions that changed upstream #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also convert some that are used in multiple crates to workspace dependencies.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2225 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 112 112
Lines 36449 36449
=======================================
+ Hits 34769 34770 +1
+ Misses 1680 1679 -1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to f11ce06. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.767 ns 99.110 ns 99.452 ns]
change: [-0.4715% +0.0789% +0.7015%] (p = 0.82 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.75 ns 117.03 ns 117.35 ns]
change: [-0.7861% +0.2983% +1.6420%] (p = 0.72 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.47 ns 117.35 ns 118.73 ns]
change: [-0.6594% +0.9522% +3.5582%] (p = 0.52 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.547 ns 101.85 ns 111.54 ns]
change: [-0.5321% +2.6100% +8.2477%] (p = 0.39 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.64 ms 111.77 ms 111.98 ms]
change: [-0.5682% -0.3353% -0.1000%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.635 ms 27.651 ms 28.679 ms]
change: [-5.4189% -0.2639% +5.1317%] (p = 0.92 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.275 ms 35.750 ms 37.263 ms]
change: [-8.2840% -2.0785% +4.5153%] (p = 0.53 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [25.273 ms 26.026 ms 26.783 ms]
change: [-8.2973% -4.5471% -0.4030%] (p = 0.03 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [40.638 ms 42.573 ms 44.547 ms]
change: [-5.6697% +0.9761% +7.7943%] (p = 0.77 > 0.05)
1-conn/1-100mb-resp/mtu-1500 (aka. Download)/client: 💔 Performance has regressed. time: [945.38 ms 954.71 ms 964.02 ms]
thrpt: [103.73 MiB/s 104.74 MiB/s 105.78 MiB/s]
change:
time: [+1.5440% +2.8537% +4.2098%] (p = 0.00 < 0.05)
thrpt: [-4.0398% -2.7745% -1.5205%]
1-conn/10_000-parallel-1b-resp/mtu-1500 (aka. RPS)/client: No change in performance detected. time: [317.13 ms 320.01 ms 323.02 ms]
thrpt: [30.958 Kelem/s 31.249 Kelem/s 31.533 Kelem/s]
change:
time: [-1.3807% -0.0257% +1.3410%] (p = 0.97 > 0.05)
thrpt: [-1.3233% +0.0257% +1.4000%]
1-conn/1-1b-resp/mtu-1500 (aka. HPS)/client: No change in performance detected. time: [34.077 ms 34.210 ms 34.343 ms]
thrpt: [29.118 elem/s 29.231 elem/s 29.346 elem/s]
change:
time: [-0.4415% +0.3058% +0.9930%] (p = 0.42 > 0.05)
thrpt: [-0.9833% -0.3049% +0.4435%]
1-conn/1-100mb-resp/mtu-1500 (aka. Upload)/client: 💔 Performance has regressed. time: [1.7192 s 1.7399 s 1.7609 s]
thrpt: [56.790 MiB/s 57.476 MiB/s 58.166 MiB/s]
change:
time: [+1.4709% +3.2062% +4.9898%] (p = 0.00 < 0.05)
thrpt: [-4.7526% -3.1066% -1.4496%]
1-conn/1-100mb-resp/mtu-65536 (aka. Download)/client: 💔 Performance has regressed. time: [113.84 ms 114.13 ms 114.40 ms]
thrpt: [874.12 MiB/s 876.23 MiB/s 878.39 MiB/s]
change:
time: [+1.1116% +1.4346% +1.7585%] (p = 0.00 < 0.05)
thrpt: [-1.7281% -1.4143% -1.0994%]
1-conn/10_000-parallel-1b-resp/mtu-65536 (aka. RPS)/client: No change in performance detected. time: [315.54 ms 319.09 ms 322.64 ms]
thrpt: [30.994 Kelem/s 31.339 Kelem/s 31.692 Kelem/s]
change:
time: [-2.3518% -0.9160% +0.5668%] (p = 0.24 > 0.05)
thrpt: [-0.5636% +0.9244% +2.4085%]
1-conn/1-1b-resp/mtu-65536 (aka. HPS)/client: Change within noise threshold. time: [33.733 ms 33.929 ms 34.143 ms]
thrpt: [29.288 elem/s 29.473 elem/s 29.644 elem/s]
change:
time: [-1.9124% -1.0629% -0.2055%] (p = 0.02 < 0.05)
thrpt: [+0.2059% +1.0743% +1.9497%]
1-conn/1-100mb-resp/mtu-65536 (aka. Upload)/client: No change in performance detected. time: [301.69 ms 385.95 ms 485.93 ms]
thrpt: [205.79 MiB/s 259.10 MiB/s 331.46 MiB/s]
change:
time: [-30.364% -2.9277% +37.867%] (p = 0.87 > 0.05)
thrpt: [-27.467% +3.0160% +43.603%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also convert some that are used in multiple crates to workspace dependencies.