Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port back code-changes from Utilu Nightly Tester Tools 3.7.1.1 #186

Closed
wants to merge 2 commits into from

Conversation

UtiluMark
Copy link
Contributor

  • Extension: The extension is now signed. Mozilla began requiring all extensions to be signed in order for them to be installable in Release and Beta versions of Firefox. Signing is done through addons.mozilla.org (AMO) and has become mandatory for all extensions.
  • Extension: Removed all partially incomplete translations
  • Extension: Removed excessive white space before line endings
  • Extension: Removed unused variables module
  • Extension: Removed references to End-of-life (EOL) extensions
  • Extension: Fixed indentation by always using spaces and never using tabs
  • Extension: Removed copy to Pastebin functionality which had become non-working due to API changes
  • Extension: Replaced non-working copy to Pastebin functionality by copy text to Clipboard functionality
  • Extension: Added spaces between the extensions when copying the list of extensions to the Clipboard
  • Extension: Removed non-working image hosts
  • Extension: Increased the size of the Customize Titlebar window
  • Extension: Improved default Customized Titlebar title
  • Extension: Optimized the order of the Customize Titlebar Variables
  • Extension: Added Customize Titlebar Variable Application Version Pretty
  • Extension: Added Customize Titlebar Variable Application Update Channel
  • Extension: Added Customize Titlebar Variable Application Update Channel Pretty (Release, ESR, beta, Aurora, Nighty, Default)
  • Extension: Added Customize Titlebar Variable Application Version and Channel
  • Extension: Added Customize Titlebar Variable Number of visible tabs
  • Extension: Fixed missing vendor in Titlebar Customization in Thunderbird
  • Extension: Marked Crash me options which do not cause a crash as such
  • Extension: Removed the unused CSS files
  • Extension: Cleaned and optimized the remaining CSS files
  • Extension: Updated and synced feature lists
  • Extension: Updated maxVersions for applications
  • Extension: Minor changes and improvements

Utilu Nightly Tester Tools

3.7.1.1 / 2015-09-10
====================

* Repository: Created a repository for Utilu Nightly Tester Tools
  *
Extension: Changed extension name to Utilu Nightly Tester Tools
  *
Extension: Changed extension ID to
{8620c15f-30dc-4dba-a131-7c5d20cf4a40}
  * Extension: Removed all
partially incomplete translations
  * Extension: Removed excessive white
space before line endings
  * Extension: Removed unused variables
module
  * Extension: Removed references to End-of-life (EOL)
extensions
  * Extension: Fixed indentation by always using spaces and
never using tabs
  * Extension: Removed copy to Pastebin functionality
which had become non-working due to API changes
  * Extension: Replaced
non-working copy to Pastebin functionality by copy text to Clipboard
functionality
  * Extension: Added spaces between the extensions when
copying the list of extensions to the Clipboard
  * Extension: Removed
non-working image hosts
  * Extension: Increased the size of the
Customize Titlebar window
  * Extension: Improved default Customized
Titlebar title
  * Extension: Optimized the order of the Customize
Titlebar Variables
  * Extension: Added Customize Titlebar Variable
Application Version Pretty
  * Extension: Added Customize Titlebar
Variable Application Update Channel
  * Extension: Added Customize
Titlebar Variable Application Update Channel Pretty (Release, ESR, beta,
Aurora, Nighty, Default)
  * Extension: Added Customize Titlebar
Variable Application Version and Channel
  * Extension: Added Customize
Titlebar Variable Number of visible tabs
  * Extension: Fixed missing
vendor in Titlebar Customization in Thunderbird
  * Extension: Marked
Crash me options which do not cause a crash as such
  * Extension:
Removed the unused CSS files
  * Extension: Cleaned and optimized the
CSS remaining files
  * Extension: Updated and synced feature lists
  *
Extension: Updated maxVersions for applications
  * Extension: Minor
changes and improvements
Utilu Nightly Tester Tools 3.7.1.1 Signed
@xabolcs xabolcs closed this Sep 10, 2015
@whimboo
Copy link
Contributor

whimboo commented Sep 17, 2015

I like a lot of those changes but it's really nothing we can land. If you want to get your changes into the core code base of NTT we would appreciate that. But it should happen in smaller steps, and only those bits which would not conflict (like the change of the addon id).

@UtiluMark
Copy link
Contributor Author

What would be the best approach to get the changes you like into the core code base of NTT?

@whimboo whimboo changed the title Utilu Nightly Tester Tools 3.7.1.1 Port back code-changes from Utilu Nightly Tester Tools 3.7.1.1 Sep 28, 2015
@whimboo
Copy link
Contributor

whimboo commented Sep 28, 2015

Hey, thanks for getting back to us and the interest to bring back your code changes into the main developer tree. So having a quick look at the list of changes I think that the following might be a good way to get it done:

  • Removal of unused files
  • Code clean-up of all the files
  • Customize title bar enhancements
  • Other PRs for remaining things

Would that work for you?

@whimboo whimboo reopened this Sep 28, 2015
@UtiluMark
Copy link
Contributor Author

Thank you. I've created a new fork of NTT, and started to re-apply the changes one by one. I've just submitted a separate pull request #187 for the first change (Removal of unused files). Is this the way to go? Then I'll create separate pull requests for the remaining changes as well.

@whimboo
Copy link
Contributor

whimboo commented Sep 28, 2015

Yes, that looks totally fine. Thanks!

@whimboo
Copy link
Contributor

whimboo commented Sep 28, 2015

If you want to be assigned to this issue I would suggest that you join our team:
https://github.com/orgs/mozilla/teams/firefox-automation-contributor

@whimboo
Copy link
Contributor

whimboo commented Sep 29, 2015

I'm going to close this PR given that we don't want to take the full code changes at once. Instead lets file a new issue for tracking purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants