-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated and synced feature lists and updated redirect links #198
Conversation
…ns to the Clipboard
This reverts commit 96da0ba.
This reverts commit 8f65d26.
…reen" This reverts commit 14b52a7.
…extensions to the Clipboard" This reverts commit 1bc25c1.
This reverts commit db02be4.
This reverts commit 7b61813.
This reverts commit 6ae1010.
This reverts commit 79332ba.
This reverts commit 1081e16.
…on by always using spaces and never using tabs
…l to createBundle below
Removal of unused files and fixed white-space issues (mozilla#188)
Updated and synced the feature lists in the README and the About window. Updated the AMO links in the README and the About window to prevent redirects. Added link to Screengrab (fix version) add-on. Part of mozilla#188
…s + Copy about:support to Clipboard reverted to Pastebin
@whimboo I've replaced "titlebar" with "title bar" everywhere except in entity names and reverted the Copy about:support to Clipboard feature to Pastebin. |
@@ -37,4 +40,5 @@ All bugs are reported to the Nightly Tester Tools component at bugzilla.mozilla. | |||
This project uses [.editorconfig](http://editorconfig.org/#overview), which sets defaults for the formatting of the code. So enjoy the use of [compatible editor](http://editorconfig.org/#download). Just download and install the corresponding plugin. | |||
|
|||
# Related Add-ons: | |||
* [Add-on Compatibility Reporter](https://addons.mozilla.org/en-US/firefox/addon/15003/) | |||
* [Screengrab (fix version)](https://addons.mozilla.org/en-US/firefox/addon/screengrab-fix-version/) | |||
* [Add-on Compatibility Reporter](https://addons.mozilla.org/en-US/firefox/addon/add-on-compatibility-reporter/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep the add-on compat reporter as first item so we have an alphabetical sorted list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Looks fine to me beside the nit. Once an update has been pushed and you (@xabolcs) are ok with the changes, can you please get it landed? Thanks. |
Sure! |
…abetical sorted list.
@xabolcs Update done, so you can get this landed. |
@UtiluMark |
FYI by default we squash all commits at the end and give the final commit a proper comment (please see git log). @UtiluMark maybe you can do it to make it easier for @xabolcs to get it landed. |
@xabolcs The benefits of preventing redirects of AMO links are that the current links have more readable URLs (for example "nightly-tester-tools" in the URL is more descriptive compared to the number "6543" of the old URL). |
Thanks @UtiluMark! |
Looks good to me. Ohh, almost forgot. @whimboo could you provide a commit message for this PR? :) |
I would like to let @UtiluMark do the squashing of commits and the commit message as pointed out in my last comment. @UtiluMark do you think you can do it? If you need help with let us know. In general make use of |
Replaced "titlebar" with "title bar" everywhere except in entity names + Copy about:support to Clipboard reverted to Pastebin Lets keep the add-on compat reporter as first item so we have an alphabetical sorted list. Updated the AMO links in the README and the About window to prevent redirects.
@whimboo it's OK to me if you would like to teach @UtiluMark contributing to NTT, but a squashed commit of this PR is already in my working copy. It's OK to me to do the squashing work. :) |
@UtiluMark, a |
@xabolcs Done, changed the commit message to "Updated and synced feature lists and updated redirect links". |
There are still 39 commits listed on this PR. You might not have pushed via -f. Also for comments we add the issue number in brackets at the end. |
@UtiluMark, sure, but @whimboo would like to let you do all the work. :) The commit message is almost correct. It should refer to #188 for now. |
@UtiluMark, take the squash & rebase exercises on the next PR! :) Merging this. |
Landed as commit f313b2b. |
Updated and synced the feature lists in the README and the About window.
Updated the AMO links in the README and the About window to prevent
redirects.
Added link to Screengrab (fix version) add-on.
Part of #188