Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add citation, prism, and dc metadata #871

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

inhumantsar
Copy link
Contributor

@inhumantsar inhumantsar commented May 20, 2024

this adds support for metadata fields common to journals and other academics-adjacent sites.

breaking changes:

  • byline is now an array of strings if multiple authors are detected (see ietf-1 and nature)

other changes:

  • JSON-LD parsing will be retried with the mainEntity field will be parsed if no relevant metadata is found on the first try
  • _normalizeByline will attempt to clean up the byline field. initially, i was going to try and swap Surname, GivenName formatting to GivenName Surname here as well, but that was going to be problematic when multiple authors are listed within a single property (as in videos-2).
  • generate-testcase.js will now attempt to follow redirects. this mirrors the behaviour of the library and was required to generate the nature test case.
  • target version for eslintrc was bumped from ES6 to ES2017 to allow generate-testcase.js's use of async and =>.

@inhumantsar inhumantsar changed the title WIP: add citation, prism, and dc metadata add citation, prism, and dc metadata Jun 11, 2024
@inhumantsar inhumantsar marked this pull request as ready for review June 11, 2024 20:51
@AramZS
Copy link

AramZS commented Jun 21, 2024

dc: is Dublin Core and it is very widely used in academic circles. I think this would be a great addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants