Fix cloning attributes to use setAttributeNode to fix #859 #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gijsk
commented
Jul 1, 2024
| @@ -0,0 +1,12 @@ | |||
| <div id="readability-page-1" class="page"> | |||
There was a problem hiding this comment.
This isn't actually very good, but it addresses the invalid markup breaking us entirely.
|
I don't love this - #509 fixed a similar issue by just using a try...catch; The other code that is now hitting the same problem doesn't have a try...catch. I could be convinced that just adding that try...catch is better than using |
|
@gijsk This has some conflicts now, but otherwise seems ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.