Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grammars #1086

Merged
merged 11 commits into from
Aug 6, 2024
Merged

Update grammars #1086

merged 11 commits into from
Aug 6, 2024

Conversation

alexle0nte
Copy link
Contributor

@alexle0nte alexle0nte commented May 9, 2024

This PR:

@aytey
Copy link

aytey commented Jul 23, 2024

@alexle0nte: is there a chance you could undraft this? It seems your PR is the only way for me to build rust-code-analysis, so it would be great if these changes could be upstreamed.

@alexle0nte
Copy link
Contributor Author

@alexle0nte: is there a chance you could undraft this? It seems your PR is the only way for me to build rust-code-analysis, so it would be great if these changes could be upstreamed.

I will start working on this PR again in the coming days. I’ve noticed that, although the tests pass, there are errors in the computation of some metrics for certain languages due to the grammar version update.

@marco-c
Copy link
Collaborator

marco-c commented Jul 25, 2024

@alexle0nte: is there a chance you could undraft this? It seems your PR is the only way for me to build rust-code-analysis, so it would be great if these changes could be upstreamed.

I will start working on this PR again in the coming days. I’ve noticed that, although the tests pass, there are errors in the computation of some metrics for certain languages due to the grammar version update.

Ciao Alex. If there are more improvements than regressions, we could consider landing the changes anyway and filing follow-up issues for the regressions.

@alexle0nte
Copy link
Contributor Author

Ciao @marco-c! Ok, so can we merge the PR even if not all tests pass, and then fix them in a new PR?

@marco-c
Copy link
Collaborator

marco-c commented Jul 26, 2024

Yes I think so, after all tests are failing on master anyway.

@marco-c
Copy link
Collaborator

marco-c commented Aug 5, 2024

@alexle0nte let me know when you're ready

@alexle0nte alexle0nte marked this pull request as ready for review August 6, 2024 11:29
@alexle0nte
Copy link
Contributor Author

@alexle0nte let me know when you're ready

It's ready for review

Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many test failures to fix, but I'll merge this so we can at least build.

@marco-c marco-c merged commit ea3e026 into mozilla:master Aug 6, 2024
1 check failed
@marco-c
Copy link
Collaborator

marco-c commented Aug 6, 2024

I've filed #1091 for the follow-up work.

@alexle0nte alexle0nte deleted the update-grammars branch February 2, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can't build rust-code-analysis by tree-sitter version conflicts with tree-sitter-rust
3 participants