-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grammars #1086
Update grammars #1086
Conversation
b010072
to
f7210f0
Compare
@alexle0nte: is there a chance you could undraft this? It seems your PR is the only way for me to build |
I will start working on this PR again in the coming days. I’ve noticed that, although the tests pass, there are errors in the computation of some metrics for certain languages due to the grammar version update. |
Ciao Alex. If there are more improvements than regressions, we could consider landing the changes anyway and filing follow-up issues for the regressions. |
Ciao @marco-c! Ok, so can we merge the PR even if not all tests pass, and then fix them in a new PR? |
Yes I think so, after all tests are failing on master anyway. |
f7210f0
to
6f9d91f
Compare
6f9d91f
to
0acfbbc
Compare
@alexle0nte let me know when you're ready |
It's ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many test failures to fix, but I'll merge this so we can at least build.
I've filed #1091 for the follow-up work. |
This PR:
tree-sitter
and grammars to the latest versions.