Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
module_id file is not optional for cudafe++
Browse files Browse the repository at this point in the history
trxcllnt committed Jan 29, 2025

Verified

This commit was signed with the committer’s verified signature.
agostbiro Agost Biro
1 parent a3e9faa commit 7766656
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions src/compiler/cicc.rs
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ impl CCompilerImpl for Cicc {
cwd: &Path,
_env_vars: &[(OsString, OsString)],
) -> CompilerArguments<ParsedArguments> {
parse_arguments(arguments, cwd, Language::Ptx, &ARGS[..], 3)
parse_arguments(arguments, cwd, Language::Ptx, &ARGS[..], 3, true)
}
#[allow(clippy::too_many_arguments)]
async fn preprocess<T>(
@@ -107,6 +107,7 @@ pub fn parse_arguments<S>(
language: Language,
arg_info: S,
input_arg_offset_from_end: usize,
module_id_file_optional: bool,
) -> CompilerArguments<ParsedArguments>
where
S: SearchableArgInfo<ArgData>,
@@ -205,7 +206,7 @@ where
"--module_id_file_name",
ArtifactDescriptor {
path: module_id_path,
optional: true,
optional: module_id_file_optional,
},
);
} else {
2 changes: 1 addition & 1 deletion src/compiler/cudafe.rs
Original file line number Diff line number Diff line change
@@ -59,7 +59,7 @@ impl CCompilerImpl for CudaFE {
cwd: &Path,
_env_vars: &[(OsString, OsString)],
) -> CompilerArguments<ParsedArguments> {
cicc::parse_arguments(arguments, cwd, Language::CudaFE, &ARGS[..], 1)
cicc::parse_arguments(arguments, cwd, Language::CudaFE, &ARGS[..], 1, false)
}
#[allow(clippy::too_many_arguments)]
async fn preprocess<T>(
2 changes: 1 addition & 1 deletion src/compiler/ptxas.rs
Original file line number Diff line number Diff line change
@@ -59,7 +59,7 @@ impl CCompilerImpl for Ptxas {
cwd: &Path,
_env_vars: &[(OsString, OsString)],
) -> CompilerArguments<ParsedArguments> {
cicc::parse_arguments(arguments, cwd, Language::Cubin, &ARGS[..], 3)
cicc::parse_arguments(arguments, cwd, Language::Cubin, &ARGS[..], 3, true)
}
#[allow(clippy::too_many_arguments)]
async fn preprocess<T>(

0 comments on commit 7766656

Please sign in to comment.