-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set user agent in webdav requests #2284
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
901f5e0
feat: add user agent to webdav requests
lukevmorris fec167d
chore: pr feedback
lukevmorris cb6084f
tidy: move function to cache/cache.rs
lukevmorris 8f371ec
fix: list reqwest as dependency of webdav
lukevmorris 90fc97f
fix: all other clients rely on reqwest
lukevmorris 677ff92
fix: conditionally compile user agent http client
lukevmorris 235ec48
chore: document user agent header
lukevmorris 1271455
Merge branch 'main' into luke/webdav-user-agent
lukevmorris 74c2df2
feat: all http clients have user agent
lukevmorris 6234221
chore: document user agent for other http clients
lukevmorris 34781e0
fix: check in http_client.rs
lukevmorris 1df6a5e
chore: centralize user agent documentation in README
lukevmorris 4897acf
chore: restore spacing
lukevmorris 769638b
chore: update wording
lukevmorris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall that we already have similar code that builds an HTTP client. Would you like to check the codebase again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! I've removed the copied code and referenced
set_user_agent
fromsrc/cache/s3.rs
.