Cleanup Android project (Minor refactorings, etc.) #1244
Conversation
|
Thank you very much! I'll take a look next week. |
There was a problem hiding this comment.
These look great, thank you very much for doing them. However if I pull the branch and run it on my S8, nothing in the webview works for some reason -- tapping the plus button brings up the file selection dialog properly, but choosing a file does not cause it to be added. Also tapping the sign in/up button does nothing. Can you confirm if things are working for you in the emulator or on a device? There could just be something wrong with my build for some reason.
android/app/src/main/java/org/mozilla/firefoxsend/MainActivity.kt
Outdated
Show resolved
Hide resolved
|
Thanks for the review, I will look into this later today and update the PR. |
Instead of holding a nullable reference to the WebView, we are now accessing the WebView using the view binding utility of Kotlin's Android Extensions. Further reading: https://kotlinlang.org/docs/tutorials/android-plugin.html
This enables debugging the app's WebView using Chrome's DevTools. https://developers.google.com/web/tools/chrome-devtools/remote-debugging/webviews
This updates the Kotlin plugin to 1.3.21 and the Gradle plugin to 3.3.2
Layout files should generally have as few nested layers as possible, because every layer affects the performance.
It is way safer to construct a JSON string using classes that are meant for doing that, instead of concatenating raw strings.
christxph
force-pushed
the
android-cleanup
branch
from
cdcac12 to
4763c58
Compare
|
Hi, Also rebased on the latest |
|
@christxph Yes, I see master being broken also. @dannycoates Did anything happen on master recently that might have broken android? |
|
Alright, I will add an instrumentation test to this branch that verifies that the sign up button does anything so that it's easier to test this issue. Edit: Seems like this is already being done in #1266 |
|
I'm going to take another swing at getting this branch running tomorrow. |
|
Master is fixed now, and this branch looks good. Thank you very much! |
Cleaned up a few files related to the Android project to follow common Android/Kotlin conventions.