Switch to YAML and GitHub data (WIP) #1063
Conversation
gh-data.py
Outdated
| for label in labels: | ||
| # Position | ||
| if label["name"] == "blocked": | ||
| assert position is None |
There was a problem hiding this comment.
It might pay to turn these assertions into warning messages instead. We can have a -Werror analogue so that we can ensure that they surface, but the idea that this whole process aborts if we mess up the labeling worries me.
| position = "blocked" | ||
| elif label["name"].startswith("position: "): | ||
| assert position is None | ||
| position = label["name"][len("position: ") :] |
There was a problem hiding this comment.
| position = label["name"][len("position: ") :] | |
| position = label["name"].removeprefix("position: ") |
&c...
Though maybe label["name"].split(": ") is a better implement.
| timeout=5, | ||
| ) | ||
| response.raise_for_status() | ||
| except Exception: |
There was a problem hiding this comment.
It might pay to check for rate limits. We have a fair number of issues and I have first-hand experience with hitting those limits. Look at this code for some clues on how to manage that.
Also, this request is not using $GITHUB_TOKEN, but I've found that doing that helps a fair bit. It means setting a header, but it means that you are less likely to hit rate limits.
There was a problem hiding this comment.
https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#primary-rate-limit-for-unauthenticated-users says 60 requests per hour, and currently this will make 12 requests. (Could make it avoid the last request by looking at the link response header.)
If we make a GH Action workflow to batch updates if the most recent run was less than 15 minutes ago or so (which seems like a good idea anyway), unauthenticated shouldn't hit the rate limit for now.
There was a problem hiding this comment.
I've experimented in https://github.com/zcorpan/gh-actions-test to get such a setup working (with help of ChatGPT 4o). The workflow will push built files to gh-pages, which I think is useful to be able to see the history.
| @@ -0,0 +1,2798 @@ | |||
| <link>'s imagesrcset and imagesizes attributes: | |||
There was a problem hiding this comment.
I'm constantly amazed at YAML and its ability to interpret what would be garbage input in other contexts. I assume that this is machine-generated.
There was a problem hiding this comment.
It is yes (json2yaml.py)
| @@ -0,0 +1,9731 @@ | |||
| [ | |||
There was a problem hiding this comment.
Does this file need to be checked in to the repository?
There was a problem hiding this comment.
No, at least not to main. My plan is to check in generated files to gh-pages with a GH Action.
|
I've made a new website here. To preview, check out this branch and start a local server ( 
|
No description provided.