Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy workflow (take 4) #1132

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix deploy workflow (take 4) #1132

merged 1 commit into from
Dec 2, 2024

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Dec 2, 2024

If there is nothing to commit for merged-data.json, git commit exits with a non-zero code.

@zcorpan
Fix deploy workflow (take 4)
1d362c3 
If there is nothing to commit for merged-data.json, git commit exits with a non-zero code.
@zcorpan zcorpan requested a review from martinthomson December 2, 2024 14:51
tantek
tantek requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@tantek tantek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nm. bash if treats "0" as "success" and thus true lol.

@tantek tantek self-requested a review December 2, 2024 19:24
@zcorpan zcorpan merged commit 24e3d10 into main Dec 2, 2024
1 check passed
@zcorpan zcorpan deleted the zcorpan/deploy-take-4 branch December 2, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tantek tantek tantek approved these changes

@martinthomson martinthomson Awaiting requested review from martinthomson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcorpan @tantek