Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment Handler API (defer) #420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Payment Handler API (defer) #420

wants to merge 2 commits into from

Conversation

marcoscaceres
Copy link
Contributor

No description provided.

@annevk
Copy link
Contributor

annevk commented Aug 6, 2020

I thought that we only used defer if we decided not to look at something. From the description it seems like we looked at this quite a bit and therefore non-harmful seems more appropriate.

tantek
tantek requested changes Aug 7, 2020
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#23 is closed, should this pull request instead be referring to #390? If so, that issue still needs a clear summary rationale in the issue itself which is then reflected here. If not, how do we close #390?

tantek
tantek requested changes Sep 2, 2020
View reviewed changes
Copy link
Member

@tantek tantek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to:

  • ✅ re-open Payment Handler API #23
  • record the reasoning for a new position of "non-harmful" in that issue, and then
  • update this pull request accordingly, referencing 23 to re-close it.

@tantek tantek mentioned this pull request Sep 2, 2020
Closed
Base automatically changed from master to main January 15, 2021 11:27
@martinthomson martinthomson mentioned this pull request Jun 27, 2022
Merged
tantek
tantek approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accurate update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tantek tantek tantek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoscaceres @annevk @tantek @martinthomson