Dark mode dashboard #816
Open
Dark mode dashboard #816
+37
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't so trivial, but likely only because I don't know how to drive bootstrap. This just overrides the rules for stuff we use. Feedback on color choice welcome; I just picked something that looked OK on my screen. Closes mozilla#814.
|
Example: |
|
This looks OK I think (but I'm not a designer). Maybe I was also going to suggest to check for color contrast issues (with Accessibility Inspector), but light mode already has some issues there so could be a follow-up. |
|
Looks like if we were using bootstrap >= 5.3 there's some built in support for dark theme and custom variables that could be set: https://getbootstrap.com/docs/5.3/customize/color-modes/. Upgrading to a new version may be more work than this patch though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't so trivial, but likely only because I don't know how to drive bootstrap. This just overrides the rules for stuff we use.
Feedback on color choice welcome; I just picked something that looked OK on my screen.
Closes #814.