Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix named artifact download in heroku push. #104

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Fix named artifact download in heroku push. #104

merged 1 commit into from
Dec 19, 2019

Conversation

La0
Copy link
Contributor

@La0 La0 commented Dec 19, 2019

No description provided.

@La0 La0 added the bug Something isn't working label Dec 19, 2019
@La0 La0 requested a review from marco-c December 19, 2019 10:09
@La0 La0 self-assigned this Dec 19, 2019
@marco-c
Copy link
Collaborator

marco-c commented Dec 19, 2019

Maybe we should have a task in .taskcluster.yml that pushes something to a test app, just to make sure it works.

@La0
Copy link
Contributor Author

La0 commented Dec 19, 2019

Integration tests are wanted in #44 for a long time...

I pushed the build produced by taskcluster as registry.hub.docker.com/babadie/taskboot:latest and re-ran the failed code-coverage task with that image : it worked.

@La0 La0 merged commit 4600213 into master Dec 19, 2019
@La0 La0 deleted the fix-heroku branch December 19, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants