-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Heroku deploy payload #49
Conversation
The payload structure was modified by #46. Also adds some logs so we can better understand what is happening
This PR has been validated locally |
Could you validate in a Taskcluster task manually created, so we can see the full execution. Please link the task here. Thanks ! |
I'm not sure how to do it but I will try |
What if we add a test push in the .taskcluster.yml of task-boot? |
It needs to find the dependencies to get the artifacts, I'm not sure how we could "override" the TASK_ID to point to another task. |
I have create a Docker image with the code if this branch: |
@Lothiraldan You can use docker image available as Taskcluster artifact in new taskcluster tasks (instead of building and pushing on a test repo). In the task definition: "image": {
"path": "public/path/to/image.tar",
"taskId": "TASK_ID",
"type": "task-image"
}, Here you could use task id |
We could have a build task in .taskcluster.yml that creates a basic image (like hello-world) and then a task that pushes it to Heroku. I'll file an issue. |
But we don't have a way to set the log level in task-boot CLI yet.
I've manually created a task for validation using the docker image I built locally: https://tools.taskcluster.net/groups/fzCU8ZX0QdyyQl3JK3Mrzg/tasks/fzCU8ZX0QdyyQl3JK3Mrzg/runs/0/logs/public%2Flogs%2Flive.log. Do we want more before merging this PR? @marco-c are you speaking about having an automated test that would be run on each commit? |
The payload structure was modified by #46. Also adds some logs so we can
better understand what is happening