Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Heroku deploy payload #49

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Fix the Heroku deploy payload #49

merged 3 commits into from
Jul 5, 2019

Conversation

Lothiraldan
Copy link
Contributor

The payload structure was modified by #46. Also adds some logs so we can
better understand what is happening

The payload structure was modified by #46. Also adds some logs so we can
better understand what is happening
@Lothiraldan
Copy link
Contributor Author

This PR has been validated locally

@La0
Copy link
Contributor

La0 commented Jul 5, 2019

Could you validate in a Taskcluster task manually created, so we can see the full execution. Please link the task here. Thanks !

@Lothiraldan
Copy link
Contributor Author

I'm not sure how to do it but I will try

@marco-c
Copy link
Collaborator

marco-c commented Jul 5, 2019

What if we add a test push in the .taskcluster.yml of task-boot?

@Lothiraldan
Copy link
Contributor Author

It needs to find the dependencies to get the artifacts, I'm not sure how we could "override" the TASK_ID to point to another task.

@Lothiraldan
Copy link
Contributor Author

I have create a Docker image with the code if this branch: lothiraldan/task-boot:fix-heroku-deploy, I'm trying to rerun / retrigger https://tools.taskcluster.net/groups/LxTuw6rUTs-B2PPzIEBtyA/tasks/eG9eMHmMT1W2dJlLPrbO9g/details with the custom image

@La0
Copy link
Contributor

La0 commented Jul 5, 2019

@Lothiraldan You can use docker image available as Taskcluster artifact in new taskcluster tasks (instead of building and pushing on a test repo).

In the task definition:

  "image": {
    "path": "public/path/to/image.tar",
    "taskId": "TASK_ID",
    "type": "task-image"
  },

Here you could use task id TtZTB3_ESHqXdrRHcp1New (from the last build)

taskboot/push.py Outdated Show resolved Hide resolved
taskboot/push.py Outdated Show resolved Hide resolved
@marco-c
Copy link
Collaborator

marco-c commented Jul 5, 2019

We could have a build task in .taskcluster.yml that creates a basic image (like hello-world) and then a task that pushes it to Heroku. I'll file an issue.

But we don't have a way to set the log level in task-boot CLI yet.
@Lothiraldan
Copy link
Contributor Author

We could have a build task in .taskcluster.yml that creates a basic image (like hello-world) and then a task that pushes it to Heroku. I'll file an issue.

I've manually created a task for validation using the docker image I built locally: https://tools.taskcluster.net/groups/fzCU8ZX0QdyyQl3JK3Mrzg/tasks/fzCU8ZX0QdyyQl3JK3Mrzg/runs/0/logs/public%2Flogs%2Flive.log. Do we want more before merging this PR?

@marco-c are you speaking about having an automated test that would be run on each commit?

@marco-c
Copy link
Collaborator

marco-c commented Jul 5, 2019

@marco-c are you speaking about having an automated test that would be run on each commit?

Yep, I've added it to the list of integration tests we should write in #44.

@La0 La0 merged commit d64517a into master Jul 5, 2019
@La0 La0 deleted the fix-heroku-deploy branch September 4, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants