Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update forecasting dag #1534

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Conversation

irrationalagent
Copy link
Contributor

This is paired with mozilla/docker-etl#67

Adding the task for the mobile non-cumulative forecast and changing the desktop non-cumulative forecast to now depend on unified metrics

@irrationalagent
Copy link
Contributor Author

@perrymcmanis144 can you take a look at this

Copy link
Contributor

@perrymcmanis144 perrymcmanis144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, you can view DAG status for this job here:
https://workflow.telemetry.mozilla.org/tree?dag_id=kpi_forecasting

@irrationalagent
Copy link
Contributor Author

I need some help clicking the big green button on this

@fbertsch fbertsch merged commit 8524cae into mozilla:main Aug 4, 2022
@kik-kik
Copy link
Contributor

kik-kik commented Aug 8, 2022

@irrationalagent the new task is failing with the following error:
FileNotFoundError: [Errno 2] No such file or directory: 'kpi-forecasting/yaml/mobile_non_cumulative.yaml'

cc: @perrymcmanis144

@kik-kik
Copy link
Contributor

kik-kik commented Aug 8, 2022

Looks like this was because CI deploy for the jobs failed due to authentication errors for your user @irrationalagent. I've triggered a redeploy and seems the job deployment worked this time. Although some of the other ones are failing due to linter checks.

@kik-kik
Copy link
Contributor

kik-kik commented Aug 8, 2022

The following two jobs fail to deploy:

  • job-desktop-mobile-mau-2020
=========================== short test summary info ============================
FAILED tests/__init__.py::FLAKE8 - AttributeError: module 'flake8.options.con...
FAILED tests/test_desktop_mau.py::FLAKE8 - AttributeError: module 'flake8.opt...
FAILED tests/test_mobile_mau.py::FLAKE8 - AttributeError: module 'flake8.opti...
========================= 3 failed, 5 passed in 2.40s ==========================

Exited with code exit status 1

CircleCI received exit code 1
  • job-quicksuggest2bq'
E   AttributeError: module 'flake8.options.config' has no attribute 'ConfigFileFinder'
=========================== short test summary info ============================
FAILED tests/__init__.py::FLAKE8 - AttributeError: module 'flake8.options.con...
FAILED tests/test_main.py::FLAKE8 - AttributeError: module 'flake8.options.co...
========================= 2 failed, 6 passed in 1.20s ==========================

Exited with code exit status 1

CircleCI received exit code 1

@kik-kik
Copy link
Contributor

kik-kik commented Aug 8, 2022

I was able to redeploy an updated version of the image using my account. The Airflow task has now completed successfully.

@kik-kik
Copy link
Contributor

kik-kik commented Aug 8, 2022

Created a PR to address the CI failures:
mozilla/docker-etl#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants