-
Notifications
You must be signed in to change notification settings - Fork 34
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Wrap train-taskcluster.sh in train_taskcluster.py
- Loading branch information
Showing
8 changed files
with
106 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #!/usr/bin/env python3 | ||
|
|
||
| import os.path | ||
| import subprocess | ||
| import sys | ||
|
|
||
| TRAINING_SCRIPT = os.path.join(os.path.dirname(__file__), "train-taskcluster.sh") | ||
|
|
||
|
|
||
| def main(args): | ||
| subprocess.run([TRAINING_SCRIPT, *args], check=True) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main(sys.argv[1:]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| import os | ||
| from unittest import mock | ||
|
|
||
| import pytest | ||
| import train_taskcluster | ||
|
|
||
| TRAIN_TASKCLUSTER_SH = os.path.normpath( | ||
| os.path.join( | ||
| os.path.dirname(os.path.realpath(__file__)), | ||
| "..", | ||
| "taskcluster", | ||
| "scripts", | ||
| "pipeline", | ||
| "train-taskcluster.sh", | ||
| ) | ||
| ) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "args", | ||
| ( | ||
| pytest.param( | ||
| [ | ||
| "model_type", | ||
| "type", | ||
| "src", | ||
| "trg", | ||
| "train_set_prefix", | ||
| "valid_set_prefix", | ||
| "model_dir", | ||
| "best_model_metric", | ||
| "alignments", | ||
| "seed", | ||
| ], | ||
| id="required_only", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| "model_type", | ||
| "type", | ||
| "src", | ||
| "trg", | ||
| "train_set_prefix", | ||
| "valid_set_prefix", | ||
| "model_dir", | ||
| "best_model_metric", | ||
| "alignments", | ||
| "seed", | ||
| "pretrained_model_mode", | ||
| "pretrained_model_type", | ||
| ], | ||
| id="with_pretrained_model", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| "model_type", | ||
| "type", | ||
| "src", | ||
| "trg", | ||
| "train_set_prefix", | ||
| "valid_set_prefix", | ||
| "model_dir", | ||
| "best_model_metric", | ||
| "alignments", | ||
| "seed", | ||
| "pretrained_model_mode", | ||
| "pretrained_model_type", | ||
| "--foo", | ||
| "--bar", | ||
| ], | ||
| id="with_extra_params", | ||
| ), | ||
| ), | ||
| ) | ||
| def test_all_args_forwarded(args): | ||
| with mock.patch("train_taskcluster.subprocess") as mocked_subprocess: | ||
| train_taskcluster.main(args) | ||
| assert mocked_subprocess.run.call_args_list == [ | ||
| mock.call([TRAIN_TASKCLUSTER_SH] + args, check=True), | ||
| ] |