Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass 'permission' to train action #859

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhearsum
Copy link
Collaborator

@bhearsum bhearsum commented Sep 23, 2024

This is required for non-generic actions as of 11.0. I mucked this up when I did the upgrade. (See https://taskcluster-taskgraph.readthedocs.io/en/latest/reference/migrations.html.)

This is required for non-generic actions as of 11.0. I mucked this up when I did the upgrade. (See https://taskcluster-taskgraph.readthedocs.io/en/latest/reference/migrations.html.)
@bhearsum
Copy link
Collaborator Author

@ahal - can you advise here? The migration guide says:

If the argument isn’t present, or you are passing generic=False, then add a new argument called permission=<cb_name>, where <cb_name> is the value of whatever you are passing to the cb_name argument.

But we're getting:

[task 2024-09-23T17:54:31.899Z] E           Exception: Unknown callback: train. Known callbacks: rebuild-cached-tasks, retrigger-decision, retrigger-disabled, retrigger, rerun, retrigger-multiple, cancel, cancel-all, add-new-jobs

(Everything seems to work fine without this patch, eg: in #858 I managed to use the train action.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant