Skip to content

Conversation

camd
Copy link
Collaborator

@camd camd commented Sep 13, 2025

Not complete yet, and not exhaustive. But this fixes a LOT of them.
It's large, so I tried to break types of fixes into different commits. But I wasn't perfect in that regard. I started getting more careful in the later commits. 😆

A few details:

  • I build it on top of the react-bootstrap PR, as it is a natural continuation.
  • I added new Puppeteer tests and fixed up the existing ones. I will ensure they do not run in CI by default, though.
  • I also fixed up many of the warnings and errors in the React Testing Library tests.
  • Upgraded the hot-reloading package, which was causing warnings as well.
  • Upgraded the "Helmet" package which handles headers and metadata, etc.

TODO:

  • Have CI run the puppeteer tests by default
  • Check how slow it is
  • Does it increase coverage

@camd camd self-assigned this Sep 13, 2025
@camd camd force-pushed the camd/react-deprecation-fixes branch from e9f41cb to 32cb302 Compare September 17, 2025 22:44
@Archaeopteryx
Copy link
Collaborator

Please rebase here when you find time.

@camd camd force-pushed the camd/react-deprecation-fixes branch from 32cb302 to 2fb0bc7 Compare September 22, 2025 15:05
@camd camd force-pushed the camd/react-deprecation-fixes branch from 2fb0bc7 to 8164177 Compare September 22, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants