Enable *warn-on-reflection* and add missing hints #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment there are several reflection calls occuring on the hot-path for request handling. This is both slow and makes it harder to compile with GraalVM. This commit enables the `*warn-on-reflection*` global on all namespaces and adds the missing type hints to locations where reflection were occuring. In some cases this required restructuring code a bit to better apply the hints.
|
Looking good, thanks! |
|
released as 0.1.30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment there are several reflection calls occuring on the hot-path for request handling. This is both slow and makes it harder to compile with GraalVM.
This commit enables the
*warn-on-reflection*global on all namespaces and adds the missing type hints to locations where reflection were occuring.In some cases this required restructuring code a bit to better apply the hints.