Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test shebangs #300

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

Conversation

devyntk
Copy link

@devyntk devyntk commented Jun 17, 2024

these cause an issue when packaging on centos9, as they do not specify python2 or python3, and thus panic during building.

@mpenning mpenning added not-a-bug Github tickets are for bugs. If it's not a new feature or a bug, please ask on Reddit/StackOverflow. wont-fix This bugfix or enhancement is declined user-error This is a problem with how the user's code was written labels Jun 18, 2024
@mpenning
Copy link
Owner

mpenning commented Jun 18, 2024

Hello @devyntk

I think the question should be asked why this is a problem to begin with. These shebangs have existed in the code base for years and it's never been a problem. By way of example, all these tests pass github CICD and yet they don't pass centos9 package build process?

However, let's just assume for the moment that there is something new in centos9 that somehow trips over them in the package build process. You have choices:

  1. Do not try to run the tests
  2. Manually chmod the files to remove the execute bit
  3. Manually remove the entire tests/ folder
  4. If you feel you absolutely must run the tests, then run cd tests && pytest . instead of whatever you're doing now.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-a-bug Github tickets are for bugs. If it's not a new feature or a bug, please ask on Reddit/StackOverflow. user-error This is a problem with how the user's code was written wont-fix This bugfix or enhancement is declined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants