Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wraparound navigation (Issue #50) #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MimmyJau
Copy link
Contributor

Add feature that lets you press left button at left-most stack to loop cursor around to right-most stack (and vice-versa). Related to Issue #50. I find it helpful personally when I play.

First pull request so welcome any feedback.

@MimmyJau MimmyJau changed the title Added wraparound navigation Added wraparound navigation (Issue #50) Nov 21, 2020
Copy link
Contributor

@greno4ka greno4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bad patch, because you duplicate code about moving cursor up and down.

@mpereira
Copy link
Owner

I'm not sure about this one, I personally like having the extremities being "physical limits", so I can press h repeatedly and end up in the leftmost stack.

I'll think about it.

@greno4ka
Copy link
Contributor

I'm not sure about this one, I personally like having the extremities being "physical limits", so I can press h repeatedly and end up in the leftmost stack.

I'll think about it.

I think it can be discussed in issue #50.

@MimmyJau
Copy link
Contributor Author

This is a bad patch, because you duplicate code about moving cursor up and down.

Good call. I made the changes in the event we decide to use this. Let me know if I understood correctly.

Copy link
Contributor

@greno4ka greno4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants