ensure reap does not enter infinite loop (#193)

lib/connection_pool/timed_stack.rb

@@ -103,8 +103,9 @@ def shutdown(reload: false, &block)
   def reap(idle_seconds, &block)
     raise ArgumentError, "reap must receive a block" unless block
     raise ArgumentError, "idle_seconds must be a number" unless idle_seconds.is_a?(Numeric)
+    raise ConnectionPool::PoolShuttingDownError if @shutdown_block
 
-    loop do
+    idle.times do
       conn =
         @mutex.synchronize do
           raise ConnectionPool::PoolShuttingDownError if @shutdown_block

test/test_connection_pool_timed_stack.rb

@@ -290,4 +290,21 @@ def test_reap_with_multiple_connections_and_idle_seconds_outside_range
     assert_empty called
     assert_equal 2, stack.idle
   end
+
+  def test_reap_does_not_loop_continuously
+    stack = ConnectionPool::TimedStack.new(2) { Object.new }
+    stack.push(Object.new)
+    stack.push(Object.new)
+
+    close_attempts = 0
+    stack.reap(0) do |conn|
+      if close_attempts >= 2
+        flunk "Reap is stuck in a loop"
+      end
+      close_attempts += 1
+      stack.push(conn)
+    end
+
+    assert_equal 2, close_attempts
+  end
 end