Track checked out created connections across reloads #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttstarck
changed the title
ttstarck
changed the title
…at the connection pool size The TimedStack class currently allows
ttstarck
force-pushed
the
track_checked_out_created_conns_through_shutdowns
branch
from
91b737c to
778310d
Compare
|
It seems unit tests are failing due to an issue in There is a fix in the works: minitest/minitest#1010 |
|
Why did ruby 2.5 pass‽‽ |
|
The other fix is to put a |
|
I don’t particularly care for the decrement created method. Could you in-line that please? |
mperham
reviewed
Aug 16, 2024
|
@ttstarck Would you be interested in commit bit here? |
|
@mperham I am not sure what you mean by "commit bit", (google shows me https://github.com/cucumber/commitbit). I'd be happy to be elevated to a higher level of permissions. |
|
It means you have commit rights to this repo. Everyone still works on PRs for major things but minor things like updating the changelog can be done directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a small bug around
ConnectionPool#reloadwhere it is possible to create more connections than the size of the pool if you runreloadwhile a connection is checked out.See the test cases defined in 4f4e5f6
These test cases all fail on the master branch. This is due to how
@createdinstance variable inConnectionPool::TimedStackis decremented, where currently it is set to 0 on#shutdown(reload: true)even if no connections were "shutdown" on the reload.