Fix context menu popping up in lists on Android #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in the bottom sheet
|
@mpiannucci I found this problem in our app on Android devices. It doesn't seem to be a common issue as I haven't came across any reports, but maybe this or similar fix could be implemented if you don't mind. |
mpiannucci
approved these changes
Jun 25, 2024
|
Is there an ETA of when this fix would be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue we noticed in our app. When list items rendered in the bottom sheet are wrapped with the
ContextMenuViewcomponent, the context menu is popping up while the list was scrolled. The problem is likely caused by the fact that the @gorhom/bottom-sheet library uses the react-native-gesture-handler, which somehow interferes with the native gesture handler. As a result, the Android's gesture detector didn't recognize the scroll event, and thus, the long press was fired, even though the user scrolled the list.Screen capture
Screen_Recording_20240624_110532_Uniswap.Dev.1.mp4
Screen_Recording_20240624_114012_Uniswap.Dev.1.mp4