Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ghc-events 0.13.0 #126

Closed
wants to merge 3 commits into from
Closed

Switch to ghc-events 0.13.0 #126

wants to merge 3 commits into from

Conversation

BinderDavid
Copy link
Collaborator

Fix #125

@BinderDavid BinderDavid requested a review from mpickering June 8, 2020 18:08
@BinderDavid
Copy link
Collaborator Author

I'm not sure whether this PR should be blocked by this: haskell/ghc-events#62

It seems that the bug in ghc-events 0.13.0 is in a function which writes files to disk, not in the parsing part.

@expipiplus1
Copy link
Contributor

That ghc-events PR has been merged now FYI

@ocharles
Copy link
Collaborator

I think this can be closed now: ad06251#diff-7470bcde200e980c19be6f8fbd32abea3d07c7fc5b203ee0df06e8772328daaa

@mpickering mpickering closed this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpickering mpickering Awaiting requested review from mpickering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to ghc-events 0.13
5 participants
@BinderDavid @expipiplus1 @ocharles @mpickering @sc-compiler