Changes in check of file path

[julia-bikova]

Previously, if you had entered a non-existent path load falling on a line 961 with an error "Not such file or directory: 'name_of_file.tmp'".
Changed check the file path: added an Exception when entering a non-existent path, plus refactoring - got rid of one variable.

[landscape-bot]

Repository health decreased by 0.68% when pulling d2c023a on julia-bikova:patch-1 into 77a00f2 on np1:develop.

• 1 new problem was found (including 0 errors and 1 code smell).
• No problems were fixed.

[landscape-bot]

Repository health decreased by 0.68% when pulling 5a95694 on julia-bikova:patch-1 into 77a00f2 on np1:develop.

• 1 new problem was found (including 0 errors and 1 code smell).
• No problems were fixed.

[ids1024]

FileNotFoundError is python 3 specific, but this change still doesn't seem necessary.

I used this command to test:

pafy.new('3jr7llQ6gNQ').streams[0].download(filepath='/tmp/doesntexist/file')

This was the result under python 3:

FileNotFoundError: [Errno 2] No such file or directory: '/tmp/doesntexist/file.temp'

And python 2:

IOError: [Errno 2] No such file or directory: u'/tmp/doesntexist/file.temp'

Do you get different results? Am I missing something?

[julia-bikova]

That's right, these results because FileNotFoundError error is specific for python 3, and will be displayed for python2 as IOError.

[ids1024]

My point is that even without this change, pafy still raises and IOError/FileNotFoundError, as that is what python's open() does in this case.

[landscape-bot]

Repository health increased by 0.51% when pulling 5a95694 on julia-bikova:patch-1 into 5fee450 on mps-youtube:develop.

• 5 new problems were found (including 0 errors and 5 code smells).
• 4 problems were fixed (including 0 errors and 4 code smells).