feat: add unsubscribe ack packet to the unsubscribe callback (#1922)

* Invoke the unsubscribe ack callback with the Unsuback packet, not null * Don't verify incorrect behavior --------- Co-authored-by: Daniel Lando <[email protected]>
mqttjs · Aug 5, 2024 · 8bcf304 · 8bcf304
1 parent 18a357c
commit 8bcf304
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/lib/handlers/ack.ts b/src/lib/handlers/ack.ts
@@ -144,7 +144,7 @@ const handleAck: PacketHandler = (client, packet) => {
 			delete client.outgoing[messageId]
 			client.messageIdProvider.deallocate(messageId)
 			client['_invokeStoreProcessingQueue']()
-			cb(null)
+			cb(null, packet)
 			break
 		}
 		default:

diff --git a/test/abstract_client.ts b/test/abstract_client.ts
@@ -1974,7 +1974,7 @@ export default function abstractTest(server, config, ports) {
 			client.once('connect', () => {
 				// callback args can be typed
 				client.unsubscribe(topic, (_, packet?: mqtt.Packet) => {
-					assert.isUndefined(packet)
+					assert.isDefined(packet)
 					client.end(true, done)
 				})
 			})