fix: move protocol "clean" after merge of parsedOptions

[mmoriani]

With this commit the removal of the “:”, for the protocol passed in connect options, was moved before the merge of parsedOptions.

parsedOptions.protocol = parsedOptions.protocol?.replace(
	/:$/,
	'',
) as MqttProtocol

opts = { ...parsedOptions, ...opts }

Previously, if someone passed as a protocol “mqtts:” (Protocol returned by the URL interface) this was “cleaned” by removing the “:”.

By moving the replace after the options merge, a backward compatibility is maintained for those, like me, who find themselves having to update deps in codes where the protocol was passed in by taking the value from the URL interface.

I know that the documentation as protocol values does not accept “:”, but so far it has accepted them anyway and fixed if url is passed.

I also think that if the URL interface returns the protocol in this way, it may be convenient to pass it directly without having to modify it.

[robertsLando]

Could you submit a quick test to cover this please?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (ad78551) to head (bc91aae).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files          24       24           
  Lines        1470     1470           
  Branches      349      349           
=======================================
  Hits         1193     1193           
  Misses        193      193           
  Partials       84       84           

Flag	Coverage Δ
unittests	81.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.