resolved golangci-lint warnings and issues

.golangci-lint.yml

@@ -52,3 +52,8 @@ linters-settings:
     checks: ["all", "-S1028"]
   staticcheck:
     checks: ["all"]
+  gosec:
+    # To specify a set of rules to explicitly exclude.
+    # Available rules: https://github.com/securego/gosec#available-rules
+    excludes:
+      - G306

localio/localio.go

@@ -29,7 +29,7 @@ import (
 func GitClone(url, directory string) error {
 	Info("git clone %s %s", url, directory)
 	_, err := git.PlainClone(directory, false, &git.CloneOptions{
-		URL: url,
+		URL:      url,
 		Progress: os.Stdout,
 	})
 	CheckIfError(err)
@@ -406,10 +406,7 @@ func Contains(s []string, str string) bool {
 // CorrectOS ... Useful for go tests
 func CorrectOS(osType string) bool {
 	operatingSystem := runtime.GOOS
-	if operatingSystem == osType {
-		return true
-	}
-	return false
+	return operatingSystem == osType
 }
 
 // BrewInstallProgram ...
@@ -487,9 +484,8 @@ func NewAptInstalled() (*AptInstalled, error) {
 	if err != nil {
 		return nil, err
 	}
-	for _, name := range installedList {
-		ai.Name = append(ai.Name, name)
-	}
+
+	ai.Name = append(ai.Name, installedList...)
 
 	return ai, nil
 }

osrelease/osrelease.go

@@ -86,8 +86,8 @@ func parseLine(line string) (key string, value string, err error) {
 
 	// Handle double quotes
 	if strings.ContainsAny(value, `"`) {
-		first := string(value[0:1])
-		last := string(value[len(value)-1:])
+		first := value[0:1]
+		last := value[len(value)-1:]
 
 		if first == last && strings.ContainsAny(first, `"'`) {
 			value = strings.TrimPrefix(value, `'`)

tmux/tmux.go

@@ -101,7 +101,7 @@ func InstallOhMyTmux(osType string, dirs *localio.Directories, packages *localio
 		}
 	}
 
-	if exists, err := localio.Exists(fmt.Sprintf("%s/.tmux.conf.local", dirs.HomeDir)); err == nil && exists == true {
+	if exists, err := localio.Exists(fmt.Sprintf("%s/.tmux.conf.local", dirs.HomeDir)); err == nil && exists {
 		return nil
 	}