Add an all.equal implementation for Bitset. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `all.equal` (or equivalently `expect_equal`) on bitsets has never worked correctly. For some reason, externalptr always compare as equal, thus, under the R6 implementation, any bitset with the same max size was treated as equal. With the recent switch to a named list and bitsets would sometimes be considered different, even where their contents were the same. More precisely, the arguments of `Bitset$new` now happen to be captured by all of the methods' environments and were being included in the comparison. A bitset created with `new(size=N)` would always be different compared to a bitset created with `new(from=ptr)`. malariasimulation has some tests that use `mockery::expect_args` to compare bitset arguments, and these tests are now broken by the new individual version.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #192 +/- ##
==========================================
- Coverage 96.28% 96.13% -0.15%
==========================================
Files 36 36
Lines 1722 1839 +117
==========================================
+ Hits 1658 1768 +110
- Misses 64 71 +7 ☔ View full report in Codecov by Sentry. |
giovannic
requested changes
Mar 11, 2024
giovannic
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
all.equal(or equivalentlyexpect_equal) on bitsets has never worked correctly. For some reason, externalptr always compare as equal, thus, under the R6 implementation, any bitset with the same max size was treated as equal.With the recent switch to a named list and bitsets would sometimes be considered different, even where their contents were the same. More precisely, the arguments of
Bitset$newnow happen to be captured by all of the methods' environments and were being included in the comparison. A bitset created withnew(size=N)would always be different compared to a bitset created withnew(from=ptr).malariasimulation has some tests that use
mockery::expect_argsto compare bitset arguments, and these tests are now broken by the new individual version.