Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow process for grouped packers #100

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Allow process for grouped packers #100

merged 4 commits into from
Nov 6, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Nov 5, 2024

Discussed with @edknock, this should actually solve the general case pretty well

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (af364ae) to head (e115d56).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          69       69           
  Lines        5383     5390    +7     
=======================================
+ Hits         5354     5361    +7     
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz richfitz marked this pull request as ready for review November 5, 2024 15:48
@richfitz
Copy link
Member Author

richfitz commented Nov 5, 2024

(coverage report now out of date)

Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense - a couple of typos, and one suggested extra test (for when code coverage works one day)

R/packer-grouped.R Outdated Show resolved Hide resolved
tests/testthat/test-packer-grouped.R Show resolved Hide resolved
tests/testthat/test-packer-grouped.R Outdated Show resolved Hide resolved
tests/testthat/test-packer-grouped.R Outdated Show resolved Hide resolved
@richfitz richfitz merged commit edc84a3 into main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants