Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package tidyup #65

Merged
merged 9 commits into from
Aug 22, 2024
Merged

Package tidyup #65

merged 9 commits into from
Aug 22, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Aug 22, 2024

  • stub of a readme
  • spelling
  • lint
  • plug coverage hole
  • update author list

@richfitz richfitz marked this pull request as ready for review August 22, 2024 08:14
This might cause a bit of an issue with the unresolved PR, but
I think we can possibly reimplement that if needed
Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - spotted a couple more corrections

@@ -23,13 +23,13 @@
##'
##' We expect that this approach will be beneficial in limited
##' situations, but where it is beneficial it is likely to result in
##' fairly large speedups:
##' fairly large speed-ups:
##'
##' * You probably need more than three regions; as the number of
##' regions increases the benefit independently accepting or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benefit OF independently

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@richfitz richfitz merged commit a5d6414 into main Aug 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants