Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callr-based parallel runner #72

Merged
merged 6 commits into from
Oct 3, 2024
Merged

callr-based parallel runner #72

merged 6 commits into from
Oct 3, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Sep 23, 2024

Merge after #71, contains those commits

A parallel runner, powered by callr. Based on the same idea in mcstate

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 91.26984% with 11 lines in your changes missing coverage. Please review.

Project coverage is 99.43%. Comparing base (3c0ffa2) to head (47ee434).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
R/runner-callr.R 90.90% 8 Missing ⚠️
R/samples.R 33.33% 2 Missing ⚠️
R/util.R 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   99.65%   99.43%   -0.23%     
==========================================
  Files          63       64       +1     
  Lines        4674     4796     +122     
==========================================
+ Hits         4658     4769     +111     
- Misses         16       27      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz
Copy link
Member Author

richfitz commented Oct 3, 2024

The missing lines here are acceptable, and largely a product of the flakey codecov action - most are unrelated, and we can go through and mop them up later.

There are some missing lines here testing the progress bar bits. I'm not actually sure how best to do this, and might come up with some gory mocking later once we are happy with the behaviour in practice

Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all runs nicely for me - Cascadia Mono is a good font to use, and somewhere in the docs we should mention that other fonts might not behave nicely.

Also codecov is complaining - covr::report() reports some things we could chase down in a future PR

@richfitz richfitz merged commit 3f721e2 into main Oct 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants