-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
callr-based parallel runner #72
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 99.65% 99.43% -0.23%
==========================================
Files 63 64 +1
Lines 4674 4796 +122
==========================================
+ Hits 4658 4769 +111
- Misses 16 27 +11 ☔ View full report in Codecov by Sentry. |
The missing lines here are acceptable, and largely a product of the flakey codecov action - most are unrelated, and we can go through and mop them up later. There are some missing lines here testing the progress bar bits. I'm not actually sure how best to do this, and might come up with some gory mocking later once we are happy with the behaviour in practice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all runs nicely for me - Cascadia Mono is a good font to use, and somewhere in the docs we should mention that other fonts might not behave nicely.
Also codecov is complaining - covr::report() reports some things we could chase down in a future PR
Merge after #71, contains those commitsA parallel runner, powered by callr. Based on the same idea in mcstate