Packer improvements #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshinsley
approved these changes
Oct 2, 2024
Co-authored-by: Wes Hinsley <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 99.67% 99.68%
=======================================
Files 63 63
Lines 4331 4398 +67
=======================================
+ Hits 4317 4384 +67
Misses 14 14 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Wes Hinsley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit (7aa5a23) fixes a small bug that I noticed when working with dust to unpack output from dust models, where we were treating "scalars" created via the
arrayargument slightly differently to those created via thescalarargument.The next couple of commits, and the bulk of this PR fixes a problem I noticed working with this, where we simply don't support packing multidimensional inputs. I don't think we'll do this very often but it felt like the current implementation was not good enough. This is surprisingly horrible to do, and I think that's reflected in the error messages and help files. This is something I feel we'll improve on over time.