Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop observers from monty #76

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Drop observers from monty #76

merged 1 commit into from
Oct 9, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Oct 9, 2024

We are going to try a new approach in a follow-on PR

We are going to try a new approach in a follow-on PR
@richfitz richfitz marked this pull request as ready for review October 9, 2024 14:32
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.38%. Comparing base (3f721e2) to head (ac8bd65).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   99.43%   99.38%   -0.05%     
==========================================
  Files          64       64              
  Lines        4796     4752      -44     
==========================================
- Hits         4769     4723      -46     
- Misses         27       29       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - a bit of coverage to catch up on later

@weshinsley weshinsley merged commit e7847b7 into main Oct 9, 2024
9 of 10 checks passed
@richfitz
Copy link
Member Author

richfitz commented Oct 9, 2024

yeah - the failure here is mostly because we reduced the denominator, but there are small holes to fill everywhere

@richfitz richfitz mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants