Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed data for the dsl #80

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Fixed data for the dsl #80

merged 5 commits into from
Oct 10, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Oct 9, 2024

As discussed with @edknock, this allows fixed data to be inserted into the DSL code.

This can be reviewed directly, or look at #79 first and then rebase to get a smaller diff. However, the fallout is not so bad either way

@richfitz richfitz marked this pull request as ready for review October 9, 2024 19:31
@richfitz richfitz requested a review from weshinsley October 9, 2024 19:35
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (af75c00) to head (0be858f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          64       64           
  Lines        4756     4789   +33     
=======================================
+ Hits         4727     4760   +33     
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edknock
Copy link
Contributor

edknock commented Oct 10, 2024

This is nice, I think very useful as I imagine people might have pre-analysis tasks that generate hyperparameters, and this seems like a great way to pass them into the dsl.

Copy link
Contributor

@weshinsley weshinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense!

@weshinsley weshinsley merged commit 6c64b5c into main Oct 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants