Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple parameters to dsl models #99

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Allow multiple parameters to dsl models #99

merged 6 commits into from
Nov 6, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Nov 5, 2024

Two somewhat related features:

  • DSL models now support (crudely) handling multiple parameters (a matrix of parameters yielding a vector of densities)
  • We can propagate the allow_multiple_parameters property when combining models

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (c0a23ee) to head (b036c5f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          69       69           
  Lines        5297     5362   +65     
=======================================
+ Hits         5268     5333   +65     
  Misses         29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richfitz richfitz marked this pull request as ready for review November 5, 2024 16:36
@weshinsley weshinsley self-requested a review November 6, 2024 08:59
@weshinsley weshinsley merged commit aa68929 into main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants