Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial support in Loader #30114

Open
Makio64 opened this issue Dec 13, 2024 · 0 comments
Open

NodeMaterial support in Loader #30114

Makio64 opened this issue Dec 13, 2024 · 0 comments
Labels

Comments

@Makio64
Copy link
Contributor

Makio64 commented Dec 13, 2024

Description

Add support to NodeMaterial in GltfLoader/Loader in general.

Solution

Assign node material directly instead of legacy material in Loaders.

Alternatives

Pass an option to the LoaderManager to return the node or legacy material version ( ex: StandardNodeMaterial / StandardMaterial) .
Then inside the loader we call this option to get the material class. This way the change can be effective for all loaders quite fast.

Additional context

From my understanding we're going to an all node material world in threejs.
In this sense it would be nice to directly got nodeMaterial when loading a 3d model.
I can open a PR if you think it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants