Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should lights_pars_begin.glsl.js be named lights_pars_fragment.glsl.js? #30216

Open
mhjacobson opened this issue Dec 26, 2024 · 0 comments
Open

Comments

@mhjacobson
Copy link

Description

All of the other pars shader chunks are named like: <functionality>_pars_<vertex_or_fragment>.glsl.js. Furthermore, other shader chunks with _begin have corresponding _end or _maps or both.

So I'm guessing the name of lights_pars_begin.glsl.js was accidental and should instead be lights_pars_fragment.glsl.js.

Reproduction steps

Look at the files in ./src/renderers/shaders/ShaderChunk/.

Code

N/A

Live example

N/A

Screenshots

No response

Version

r170

Device

No response

Browser

No response

OS

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant