Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Add event bus to sync locale between nova-translatable field instances #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdupoiron
Copy link

No description provided.

@mrmonat
Copy link
Owner

mrmonat commented Sep 14, 2018

Hi, thanks for your pull request, i like the idea, but I think we could use the global Nova Event Bus, instead of using our own? (what do you think?)
I saw a parameter dontEmit, where would this be set? I think we should make it configurable in config/translatable.php and add an extra method to override it something linke ->emitChanges(true/false)

@cdupoiron
Copy link
Author

Hi,
OK, great idea, is there a doc about the global Nova Event Bus?

OK to make it configurable

@mrmonat
Copy link
Owner

mrmonat commented Sep 14, 2018

Yes, you can find the documentation for the Event Bus here: https://nova.laravel.com/docs/1.0/customization/frontend.html#javascript

@cdupoiron
Copy link
Author

OK, thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants