Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install wakatime-cli binary if missing #5

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gwennlbh
Copy link
Contributor

Client plugins should install wakatime-cli themselves, see
https://wakatime.com/help/creating-plugin#plugin-init:wakatime-cli

@gwennlbh gwennlbh force-pushed the install-wakatime-cli branch from 00e3d9f to 2364037 Compare July 13, 2024 12:32
@mrnossiom mrnossiom self-assigned this Jul 13, 2024
@gwennlbh gwennlbh mentioned this pull request Jul 13, 2024
4 tasks
@gwennlbh gwennlbh force-pushed the install-wakatime-cli branch from 2364037 to f8ea2d2 Compare July 13, 2024 19:42
@gwennlbh
Copy link
Contributor Author

gwennlbh commented Aug 1, 2024

Hi! Just checking in, have you had the time to look at this? If you don't thats fine, ill release a first version of zed wakatime without this merged in ;)

@mrnossiom
Copy link
Owner

Hi ewen,

I have read Wakatime guidelines for plugins. This was more of a design decision than just straight not implementing it. I personally prefer to manage myself upgrades through declarative configuration.

This said, I am more than open to dicussion. I see how this could refrain users. I see two solutions:

  • Update check and installation is instead implemented at the editor plugin level (e.g. in https://github.com/ewen-lbh/zed-wakatime).
  • It is possible to integrate this at the LSP level with a flag (either CLI flag, non-standard key in the wakatime config, cargo feature).

Concerning the PR, a few comments:

  • You should take into account the $WAKATIME_HOME env var. Wakatime is not always at ~/.wakatime.
  • I think it would be cleaner to move installation and update check code to its own module.

Bonne journée

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants