Improved CI - check fmt (#156)

* Improved CI
Changed the scala setup plugin to a maintained action.
Pipeline to check if the format is correct.
Added a cache to improve the speed in CI runs.
Updated checkout action to the latest version.

* Update spark versions to latest.

.github/workflows/ci-quality.yml

@@ -0,0 +1,23 @@
+name: CI-quality
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+
+jobs:
+  build:
+    strategy:
+      fail-fast: false
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: coursier/cache-action@v6
+        with:
+          extraKey: quality-check
+      - uses: coursier/setup-action@v1
+        with:
+          jvm: zulu:8
+      - name: ScalaFmt
+        id: fmt
+        run: sbt scalafmtCheckAll

.github/workflows/ci.yml

@@ -10,11 +10,16 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        spark: ["3.1.3","3.2.1", "3.3.2", "3.4.3", "3.5.1"]
+        spark: ["3.1.3","3.2.4", "3.3.4", "3.4.3", "3.5.1"]
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
-      - uses: olafurpg/setup-scala@v10
+      - uses: actions/checkout@v4
+      - uses: coursier/cache-action@v6
+        with:
+          extraKey: ${{ matrix.spark  }}
+      - uses: coursier/setup-action@v1
+        with:
+          jvm: zulu:8
       - name: Test
         run: sbt -Dspark.testVersion=${{ matrix.spark  }} +test
       - name: Benchmark

core/src/main/scala/com/github/mrpowers/spark/fast/tests/SchemaComparer.scala

@@ -32,7 +32,7 @@ object SchemaComparer {
       ignoreNullable: Boolean = false,
       ignoreColumnNames: Boolean = false,
       ignoreColumnOrder: Boolean = true
-  ) = {
+  ): Unit = {
     require((ignoreColumnNames, ignoreColumnOrder) != (true, true), "Cannot set both ignoreColumnNames and ignoreColumnOrder to true.")
     if (!SchemaComparer.equals(actualDS.schema, expectedDS.schema, ignoreNullable, ignoreColumnNames, ignoreColumnOrder)) {
       throw DatasetSchemaMismatch(