put magic number in constant

mrpowers-io · Nov 19, 2024 · b79adc4 · b79adc4
1 parent 3a3dc3b
commit b79adc4
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/core/src/main/scala/com/github/mrpowers/spark/fast/tests/SchemaComparer.scala b/core/src/main/scala/com/github/mrpowers/spark/fast/tests/SchemaComparer.scala
@@ -7,6 +7,8 @@ import org.apache.spark.sql.Dataset
 import org.apache.spark.sql.types._
 
 object SchemaComparer {
+  private val INDENT_GAP      = 5
+  private val DESCRIPTION_GAP = 21
   case class DatasetSchemaMismatch(smth: String) extends Exception(smth)
   private def betterSchemaMismatchMessage(actualSchema: StructType, expectedSchema: StructType): String = {
     showProductDiff(
@@ -20,8 +22,7 @@ object SchemaComparer {
   private def treeSchemaMismatchMessage[T](actualSchema: StructType, expectedSchema: StructType): String = {
     def flattenStrucType(s: StructType, indent: Int): (Seq[(Int, StructField)], Int) = s
       .foldLeft((Seq.empty[(Int, StructField)], Int.MinValue)) { case ((fieldPair, maxWidth), f) =>
-        // 5 char for each level of indentation, 21 char for gap, and description words
-        val gap         = indent * 5 + 21 + f.name.length + f.dataType.typeName.length + f.nullable.toString.length
+        val gap         = indent * INDENT_GAP + DESCRIPTION_GAP + f.name.length + f.dataType.typeName.length + f.nullable.toString.length
         val pair        = fieldPair :+ (indent, f)
         val newMaxWidth = scala.math.max(maxWidth, gap)
         f.dataType match {