Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package version upgrade #131

Merged
merged 12 commits into from
Aug 8, 2024
Merged

Conversation

zeotuan
Copy link
Collaborator

@zeotuan zeotuan commented Aug 7, 2024

Chunked from #122 changes relates to Version Upgrade
Add CI test for spark 3.3 and 3.4
Upgrade scala version to 2.13.13 and 2.11.17
Upgrade Scalatest to 2.13.18
Use more modern sbt syntax

@zeotuan zeotuan mentioned this pull request Aug 7, 2024
5 tasks
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thank you for that contribution! I left few minor comments.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
project/plugins.sbt Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
.scalafmt.conf Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
project/plugins.sbt Outdated Show resolved Hide resolved
Copy link
Collaborator

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@alfonsorr alfonsorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to review the test changes, but to me, they look great.

@SemyonSinchenko SemyonSinchenko merged commit 165b1c0 into mrpowers-io:main Aug 8, 2024
5 checks passed
@SemyonSinchenko
Copy link
Collaborator

@zeotuan Thank you for that contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants