-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package version upgrade #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, thank you for that contribution! I left few minor comments.
src/test/scala/com/github/mrpowers/spark/fast/tests/DataFrameComparerTest.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/github/mrpowers/spark/fast/tests/DataFrameComparerTest.scala
Show resolved
Hide resolved
- add support spark 3.5 - drop 2.x support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to review the test changes, but to me, they look great.
@zeotuan Thank you for that contribution! |
Chunked from #122 changes relates to Version Upgrade
Add CI test for spark 3.3 and 3.4
Upgrade scala version to 2.13.13 and 2.11.17
Upgrade Scalatest to 2.13.18
Use more modern sbt syntax