Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content GET filter #7

Closed
wants to merge 1 commit into from
Closed

Add content GET filter #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions teddycloud/rootfs/etc/nginx/servers/ingress.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ server {
sub_filter '.concat("/web",' '.concat("$http_x_ingress_path/web",';
sub_filter 'apiGetTeddyCloudApiRaw("/api/' 'apiGetTeddyCloudApiRaw("$http_x_ingress_path/api/';
sub_filter 'apiGetTeddyCloudApiRaw(`/api/' 'apiGetTeddyCloudApiRaw(`$http_x_ingress_path/api/';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an actual need for duplicated filters?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are not duplicate, just different strings `` vs ""

sub_filter 'apiGetTeddyCloudApiRaw(`/content/' 'apiGetTeddyCloudApiRaw(`$http_x_ingress_path/content/';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find the /content/ in the minimized js, are you sure it's in there?
I believe the content is pulled out of the json for each tonie that the API presents.

Copy link
Author

@eSKape-debug eSKape-debug Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now i understand - ok backend builds the URL here: https://github.com/toniebox-reverse-engineering/teddycloud/blob/9e05ef8fc4a7d66f1e38db6a444c4a0d49af991f/src/handler_api.c#L2638

sub_filter 'apiPostTeddyCloudRaw(`/api/' 'apiPostTeddyCloudRaw(`$http_x_ingress_path/api/';
sub_filter 'apiPostTeddyCloudRaw("/api/' 'apiPostTeddyCloudRaw("$http_x_ingress_path/api/';
sub_filter 'apiPostTeddyCloudFormDataRaw("/api/' 'apiPostTeddyCloudFormDataRaw("$http_x_ingress_path/api/';
Expand Down