Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: increase specificity of downloadTriggerUrl filter #8

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

kraiz
Copy link
Contributor

@kraiz kraiz commented Nov 30, 2024

Proposed Changes

previous version of this filter matched two spots. we just want to match the assignment, not where it's used as parameter of useState()

Related Issues

#5

@mrueg mrueg changed the title increase specificity of downloadTriggerUrl filter bugfix: increase specificity of downloadTriggerUrl filter Nov 30, 2024
@mrueg mrueg added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Nov 30, 2024

Verified

This commit was signed with the committer’s verified signature.
previous version matched two spots. we just wanne match the assignment, not where it's used as parameter of useState()
@mrueg mrueg merged commit 324060f into mrueg:main Nov 30, 2024
11 checks passed
@mrueg
Copy link
Owner

mrueg commented Nov 30, 2024

Thanks for your contribution!

@kraiz kraiz deleted the patch-1 branch December 1, 2024 11:54
@kraiz
Copy link
Contributor Author

kraiz commented Dec 1, 2024

thx for the addon :)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants