Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow error for NNI distance between large trees #129

Merged
merged 36 commits into from
Jan 10, 2025
Merged

Conversation

ms609
Copy link
Owner

@ms609 ms609 commented Jan 9, 2025

No description provided.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 83.78378% with 12 lines in your changes missing coverage. Please review.

Project coverage is 98.82%. Comparing base (47353a7) to head (15e8f05).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/tree_distances.cpp 75.00% 7 Missing ⚠️
src/spr.cpp 69.23% 4 Missing ⚠️
src/nni_distance.cpp 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   99.73%   98.82%   -0.92%     
==========================================
  Files          37       37              
  Lines        2605     2628      +23     
==========================================
- Hits         2598     2597       -1     
- Misses          7       31      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ms609 ms609 marked this pull request as ready for review January 10, 2025 16:22
@ms609 ms609 merged commit 65a6e58 into master Jan 10, 2025
8 checks passed
@ms609 ms609 deleted the m1-san branch January 10, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant