Use JSON::Serializable instead of deprecated JSON.mapping

msa7 · Sep 22, 2020 · dff240a · dff240a
1 parent dc16e17
commit dff240a
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 50 deletions.
diff --git a/src/multi_auth/providers/facebook.cr b/src/multi_auth/providers/facebook.cr
@@ -29,20 +29,20 @@ class MultiAuth::Provider::Facebook < MultiAuth::Provider
   end
 
   private class FbUser
+    include JSON::Serializable
+
     property raw_json : String?
     property access_token : OAuth2::AccessToken?
     property picture_url : String?
 
-    JSON.mapping(
-      id: String,
-      name: String,
-      last_name: String?,
-      first_name: String?,
-      email: String?,
-      location: String?,
-      about: String?,
-      website: String?
-    )
+    property id : String
+    property name : String
+    property last_name : String?
+    property first_name : String?
+    property email : String?
+    property location : String?
+    property about : String?
+    property website : String?
   end
 
   private def fetch_fb_user(code)

diff --git a/src/multi_auth/providers/github.cr b/src/multi_auth/providers/github.cr
@@ -30,20 +30,22 @@ class MultiAuth::Provider::Github < MultiAuth::Provider
   end
 
   private class GhUser
+    include JSON::Serializable
+
     property raw_json : String?
     property access_token : OAuth2::AccessToken?
 
-    JSON.mapping(
-      id: {type: String, converter: String::RawConverter},
-      name: String,
-      email: String?,
-      login: String,
-      location: String?,
-      bio: String?,
-      avatar_url: String?,
-      blog: String?,
-      html_url: String?
-    )
+    @[JSON::Field(converter: String::RawConverter)]
+    property id : String
+
+    property name : String
+    property email : String?
+    property login : String
+    property location : String?
+    property bio : String?
+    property avatar_url : String?
+    property blog : String?
+    property html_url : String?
   end
 
   private def fetch_gh_user(code)

diff --git a/src/multi_auth/providers/twitter.cr b/src/multi_auth/providers/twitter.cr
@@ -28,19 +28,21 @@ class MultiAuth::Provider::Twitter < MultiAuth::Provider
   end
 
   private class TwUser
+    include JSON::Serializable
+
     property raw_json : String?
     property access_token : OAuth::AccessToken?
 
-    JSON.mapping(
-      id: {type: String, converter: String::RawConverter},
-      name: String,
-      screen_name: String,
-      location: String?,
-      description: String?,
-      url: String?,
-      profile_image_url: String?,
-      email: String?
-    )
+    @[JSON::Field(converter: String::RawConverter)]
+    property id : String
+
+    property name : String
+    property screen_name : String
+    property location : String?
+    property description : String?
+    property url : String?
+    property profile_image_url : String?
+    property email : String?
   end
 
   private def fetch_tw_user(oauth_token, oauth_verifier)

diff --git a/src/multi_auth/providers/vk.cr b/src/multi_auth/providers/vk.cr
@@ -36,12 +36,13 @@ class MultiAuth::Provider::Vk < MultiAuth::Provider
   end
 
   class VkTitle
-    JSON.mapping(
-      title: String
-    )
+    include JSON::Serializable
+    property title : String
   end
 
   class VkUser
+    include JSON::Serializable
+
     property raw_json : String?
     property access_token : OAuth2::AccessToken?
     property email : String?
@@ -51,25 +52,24 @@ class MultiAuth::Provider::Vk < MultiAuth::Provider
       "#{last_name} #{first_name}"
     end
 
-    JSON.mapping(
-      id: {type: String, converter: String::RawConverter},
-      last_name: String?,
-      first_name: String?,
-      site: String?,
-      city: VkTitle?,
-      country: VkTitle?,
-      domain: String?,
-      about: String?,
-      photo_max_orig: String?,
-      mobile_phone: String?,
-      home_phone: String?
-    )
+    @[JSON::Field(converter: String::RawConverter)]
+    property id : String
+
+    property last_name : String?
+    property first_name : String?
+    property site : String?
+    property city : VkTitle?
+    property country : VkTitle?
+    property domain : String?
+    property about : String?
+    property photo_max_orig : String?
+    property mobile_phone : String?
+    property home_phone : String?
   end
 
   class VkResponse
-    JSON.mapping(
-      response: Array(VkUser),
-    )
+    include JSON::Serializable
+    property response : Array(VkUser)
   end
 
   private def fetch_vk_user(code)