-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repos with symlinks not working anymore since #12 #13
base: master
Are you sure you want to change the base?
Conversation
Oh, I just read in #6 that not supporting symlinks was intended. This is unfortunate as we are using symlinks heavily in the Odoo ecosystem with setuptools-odoo. @msabramo @stefanholek @sciyoshi Would there be a simple solution to support the simple test case I provide here? I confess I don't yet fully understand #12 and why it breaks this use case. |
@sbidoul #12 was to avoid walking into directories that aren't managed by git. It works by checking the output of |
Just encountered this issue also. It also drops directories that are managed by git but are above setup.py. Here is our use case for Django. We generate multiple packages from the same git repository. This would give us a site_common tree within each of our packages prior to 4885c65.
|
In 6498f29 I provide a solution which should not negatively impact performance and properly ignore out-of-git symlinks |
@electroniceagle would you like to test this for your use case? |
I just noticed that setuptools_scm has the same feature and is recommanded by the setuptools documentation, so I'll try that one. |
This is now implemented in setuptools_scm 2.1 |
Here is a test illustrating a use case that was working with 1.1 and is broken with 1.2.
Reverting 4885c65 makes the test pass.
Now looking for a proper fix.